Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Path type #55

Closed
robertodr opened this issue Mar 28, 2019 · 2 comments
Closed

Add a Path type #55

robertodr opened this issue Mar 28, 2019 · 2 comments
Labels
enhancement New feature or request RFC Planning and design discussions

Comments

@robertodr
Copy link
Contributor

In the discussion over #51 it emerged that filesystem paths should be allowed to have richer semantics than that allowed by simple strings.

@robertodr robertodr added enhancement New feature or request RFC Planning and design discussions labels Mar 28, 2019
@robertodr
Copy link
Contributor Author

I don't think a specific path type is needed. Casting to a Python Path is actually counterproductive, as it can be natively serialized to JSON. Even that were possible, deserialization in any other language would surely lead to surprises. A case-sensitive string type would capture the need to skip case normalization and checks on paths could still be performed easily.

@bast
Copy link
Member

bast commented Jul 18, 2019

We concluded that we will not do this. We stick with str type for paths and since we do not automatically normalize values, not a problem.

@bast bast closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RFC Planning and design discussions
Projects
None yet
Development

No branches or pull requests

2 participants