Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write tests #14

Open
bluegenes opened this issue May 18, 2021 · 3 comments
Open

write tests #14

bluegenes opened this issue May 18, 2021 · 3 comments

Comments

@bluegenes
Copy link
Member

bluegenes commented May 18, 2021

@bluegenes
Copy link
Member Author

bluegenes commented May 19, 2021

@taylorreiter

Proposed road map:

  1. using your existing repo, add input/output specification capability into the config file
  2. Try small or local test data using ^ framework / testing config file
    • merge this version intomain
  3. Build testing framework using test data
    • test_snakemake file / pytest stuff
    • data download as needed
    • gh-actions, etc etc
  4. Integrate protein changes, which mostly involve:
    • sketch instead of compute
    • alpha-ksize wildcard / folder, to enable add'l alphas
    • add testing for protein
  5. Continue with other enhancements/changes...

If you are up for doing 1/2, I can work on 3/4 (or we can work on 3 jointly). Thoughts?

@taylorreiter
Copy link
Member

  • what is the smallest test data we can use?

So for the variable selection code to work/produce results, the files need to be kind of big. I subsetted to what I think is the smallest set, and it's still 5gb. Spacegraphcats gets around large test data by having the Makefile download large files before executing tests.

The signatures that the majority of the pipeline actually runs on will be small, which is good.

I'm working on uploading this data somewhere (probably osf), and will update when it's uploaded.

using your existing repo, add input/output specification capability into the config file

I don't totally know what you mean by this...can you link to some code that does what you're talking about? I saw you changed the input metadata to read from conf, do you mean do that for other things as well?

@bluegenes
Copy link
Member Author

ok!

I don't totally know what you mean by this...can you link to some code that does what you're talking about? I saw you changed the input metadata to read from conf, do you mean do that for other things as well?

yes! Just would be good to change all inputs to read from a config, so you wouldn't need to worry about input data being in the right location (e.g. inputs/raw).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants