Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rapidhash #48

Open
bigerl opened this issue Jun 18, 2024 · 2 comments
Open

add rapidhash #48

bigerl opened this issue Jun 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bigerl
Copy link
Member

bigerl commented Jun 18, 2024

There seems to be a improved version of wyhash. We should add it as a new hashing scheme.

https://github.com/Nicoshev/rapidhash

Please also test how it performs in https://github.com/martinus/map_benchmark

Interesting for us are especially tsl::sparse_map and ankerl::unordered_dense in the configurations and it's segmented version, as well as with the bucket types standard and big.

@bigerl bigerl added enhancement New feature or request good first issue Good for newcomers labels Jun 18, 2024
@tigerwagh
Copy link

Hi,

I came across the issue regarding the integration of the improved version of wyhash and its performance testing with tsl::sparse_map and ankerl::unordered_dense in various configurations.

I am interested in contributing to this enhancement and would like to start working on it. Could you please confirm if the issue is still open and if I can proceed with the implementation and benchmarking?

@bigerl
Copy link
Member Author

bigerl commented Jun 18, 2024

Hi @tigerwagh,
the issue is open and has not been picked up yet. A contribution would be very appreciated. For a contribution please fork the repo and make a pull request. Also, please remind me to change the repo license to MIT+BSD so that you can freely use it in any private projects you might have.

If you just want to benchmark it in https://github.com/martinus/map_benchmark, I would be happy if you would share your results and a link to the code here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants