-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation improvement #2
Comments
Couldn't agree more about the documentation. I was unsure if people even had any interest in this kind of library and therefore didn't invest too much of my time on the docs. I need to figure out if it's enough to simply improve the readme file on GitHub or make use of GitHub's wiki section instead. I'd be very interested in knowing what have been the most problematic and hard to figure out things when it comes to Penumbra. Also, any ideas on how to improve the API itself are welcome. |
The radius property of the The radius does not reflect how far the light rays reach, instead it determines the radius of the light source (the circle where light emanates from). It will only affect the shadows (how big is penumbra and umbra regions of a shadow). Scale is what determines how far the light rays travel. |
You see ! You may change the properties' names and/or add documentation about them. IMHO: replace radius/scale by size/radius-distance-attenuation(distance) or something more relevant and meaningful. Allow defining the size of the light is unusual, the common approach is to consider a point light as a single point (for "big" light, we have to create a sphere and using an emissive texture, for example in Unity), so its name. |
I believe Penumbra deserve a better documentation, including subtle tweaking of items parameter (lights and hulls), some tips & tricks (like what is fastest/cutest for example) etc
I know I'm not the best to talk about writing documentation :P and I understand what it could be, but as good as a library is, it is nothing without proper documentation, hope you'll agree. You can also let me know if you need some help, as a beginner users, I can help at least by pointing where I have some trouble understand something or deal with an issue on my own.
The text was updated successfully, but these errors were encountered: