Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong endpoint in zclFreepadApp_SendKeysToBinds #20

Open
ai-xyz opened this issue Mar 12, 2021 · 1 comment
Open

Wrong endpoint in zclFreepadApp_SendKeysToBinds #20

ai-xyz opened this issue Mar 12, 2021 · 1 comment

Comments

@ai-xyz
Copy link

ai-xyz commented Mar 12, 2021

Hi, first of all really nice piece of software!

In the file zcl_freepadapp.c the function zclFreepadApp_SendKeysToBinds has the case

        zclGeneral_SendLevelControlStepWithOnOff(endPoint, &inderect_DstAddr, LEVEL_STEP_DOWN, FREEPADAPP_LEVEL_STEP_SIZE,
                                                 FREEPADAPP_LEVEL_TRANSITION_TIME, TRUE, bdb_getZCLFrameCounter());

        zclLighting_ColorControl_Send_StepColorCmd(endPoint - 1, &inderect_DstAddr, -1000, 0, 0, true, bdb_getZCLFrameCounter());

As far as i understand both endpoints should be endPoint.

@ai-xyz
Copy link
Author

ai-xyz commented Mar 12, 2021

In the same function, it also looks as if
zclLighting_ColorControl_Send_StepColorCmd(endPoint - 1, &inderect_DstAddr, 1000, 0, 0, true, bdb_getZCLFrameCounter()); line 166
cancels
zclLighting_ColorControl_Send_StepColorCmd(endPoint - 1, &inderect_DstAddr, FREEPADAPP_COLOR_LEVEL_STEP_X_SIZE, FREEPADAPP_COLOR_LEVEL_STEP_Y_SIZE, FREEPADAPP_COLOR_LEVEL_TRANSITION_TIME, true, bdb_getZCLFrameCounter()); line 191
out.
I guess lines 166 and 179 should be commented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant