Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo broken locally and features #35

Closed
jasondavis opened this issue Mar 8, 2016 · 2 comments
Closed

Demo broken locally and features #35

jasondavis opened this issue Mar 8, 2016 · 2 comments

Comments

@jasondavis
Copy link

When I install locally I cannot seem to get any of the tools to work on my canvas. The demo in this repo, the only tool that sort of works is the text tool and it lets me enter text but as soon as focus is lost from the text input, it disappears from view. The other tools when applied to the canvas do not show up at all for me.

I tried in Firefox, Chrome, and IE.

The demo on the website linked here does work for me though and based on that demo,

Couple questions based on my usage of the demo site:

  • Is it possibble to click a and drag to re-position any items?
  • Is it possibble to click and delete an item, beside from using the undo tool?
  • I know you can set the color, line thickness, etc from the JS object options. Would it be possibble to update these dynamically as well? For example if I build a selection element for color and line thickness for user to select and use an onchange event, can I call a function in this library to set those new values after the library has been initiated already?

Thanks for any help. I am trying to add basic annotation tools to my screenshot chrome extension. User can create a selection area/cropped screenshot now and then I want to use this libraruy to allow them to edit it before it is uploaded to server.

@smirolo
Copy link
Contributor

smirolo commented Mar 10, 2016

Thanks for the detail report @jasondavis. I will look at why the in-repo demo is broken over the week-end. Stay tuned.

Though we have tried to keep the annotate tool as simple as possible for the use case of reporting UX issues on a webpage, some of your suggestions sound really good. If you are interested to create a pull request, I will merge it.

@smirolo
Copy link
Contributor

smirolo commented Mar 13, 2016

Hi @jasondavis. I added the missing bootstrap vendor files. Opening test.html locally on my machine now enables annotation of the image. I also added 3 separate issues (#36, #37, #38) to track the features you proposed here. Thanks again for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants