From 13f4b1cfa7b27302726fb5274a0d53c89ddc63c3 Mon Sep 17 00:00:00 2001 From: Dave Date: Thu, 25 Apr 2024 15:08:35 +0200 Subject: [PATCH] post devel merge fix --- dlt/common/destination/capabilities.py | 1 - dlt/destinations/impl/clickhouse/__init__.py | 1 - tests/load/pipeline/test_scd2.py | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/dlt/common/destination/capabilities.py b/dlt/common/destination/capabilities.py index 9c633e6a20..7ee1cb5695 100644 --- a/dlt/common/destination/capabilities.py +++ b/dlt/common/destination/capabilities.py @@ -54,7 +54,6 @@ class DestinationCapabilitiesContext(ContainerInjectableContext): insert_values_writer_type: str = "default" supports_multiple_statements: bool = True supports_clone_table: bool = False - scd2_high_timestamp: pendulum.DateTime = HIGH_TS """High timestamp used to indicate active records in `scd2` merge strategy.""" """Destination supports CREATE TABLE ... CLONE ... statements""" diff --git a/dlt/destinations/impl/clickhouse/__init__.py b/dlt/destinations/impl/clickhouse/__init__.py index 91cff79d53..bead136828 100644 --- a/dlt/destinations/impl/clickhouse/__init__.py +++ b/dlt/destinations/impl/clickhouse/__init__.py @@ -25,7 +25,6 @@ def capabilities() -> DestinationCapabilitiesContext: # https://stackoverflow.com/questions/68358686/what-is-the-maximum-length-of-a-column-in-clickhouse-can-it-be-modified caps.max_identifier_length = 255 caps.max_column_identifier_length = 255 - caps.scd2_high_timestamp = pendulum.datetime(2299, 12, 31) # this is the max datetime... # ClickHouse has no max `String` type length. caps.max_text_data_type_length = sys.maxsize diff --git a/tests/load/pipeline/test_scd2.py b/tests/load/pipeline/test_scd2.py index d5d76580d7..e8baa33ff3 100644 --- a/tests/load/pipeline/test_scd2.py +++ b/tests/load/pipeline/test_scd2.py @@ -81,7 +81,7 @@ def assert_records_as_set(actual: List[Dict[str, Any]], expected: List[Dict[str, for dconf in destinations_configs(default_sql_configs=True, supports_merge=True) ] + [ - (dconf, True, None, pendulum.DateTime(3234, 12, 31, 22, 2, 59)) # arbitrary timestamp + (dconf, True, None, pendulum.DateTime(2099, 12, 31, 22, 2, 59)) # arbitrary timestamp for dconf in destinations_configs(default_sql_configs=True, supports_merge=True) ] + [ # test nested columns and validity column name configuration only for postgres and duckdb