Suggestion: Add new Types for non-empty-string and positive-int

[ThomasLandauer]

Feature Request

What

Implement something like Types:NON_EMPTY_STRING and Types::POSITIVE_INT.

Why

Since Symfony 7.2, UserInterface::getUserIdentifier() is annotated with @return non-empty-string.

So if you're fetching that user identifier from the database, PHPStan will report something like:

Property App\Entity\User::$... type mapping mismatch: database can contain string but property expects non-empty-string.

So instead of telling everybody to just @phpstan-ignore it (e.g. at phpstan/phpstan-doctrine#204), I'm wondering if it would be possible to fix the root cause :-)

[curry684]

The root cause is not with Doctrine, as it does not take any responsibility for content validation whatsoever. As correctly pointed out in the linked issue you can always break it by directly editing the database anyway.

The true root cause is setting an entity field to non-empty-string. Your validation layers should ensure it does not get invalid content, not Doctrine or PHPStan.