Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using CDN for install script #15400

Open
richlander opened this issue Jan 11, 2025 · 0 comments
Open

Switch to using CDN for install script #15400

richlander opened this issue Jan 11, 2025 · 0 comments

Comments

@richlander
Copy link
Member

We're relying on the install script being delivered via the website not the CDN. That needs to be changed, in both the .ps1 and .sh files

local install_script_url="https://dotnet.microsoft.com/download/dotnet/scripts/$dotnetInstallScriptVersion/dotnet-install.sh"

There are also multiple references to the website.

arcade/eng/common/tools.sh

Lines 310 to 311 in f213557

echo "Curl failed; dumping some information about dotnet.microsoft.com for later investigation"
echo | openssl s_client -showcerts -servername dotnet.microsoft.com -connect dotnet.microsoft.com:443 || true

and

# Enable repos to use a particular version of the on-line dotnet-install scripts.
# default URL: https://dotnet.microsoft.com/download/dotnet/scripts/v1/dotnet-install.sh
dotnetInstallScriptVersion=${dotnetInstallScriptVersion:-'v1'}

I see that the install script is actually in the same directory. Why not just use it?

https://github.com/dotnet/arcade/blob/main/eng/common/dotnet-install.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant