Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CleanRepo] Orphaned images being mistakenly removed #445

Open
davidbritch opened this issue Nov 27, 2024 · 0 comments
Open

[CleanRepo] Orphaned images being mistakenly removed #445

davidbritch opened this issue Nov 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@davidbritch
Copy link

davidbritch commented Nov 27, 2024

While using cleanrepo to remove orphaned images on xamarin-docs-pr I discovered the following markdown formats weren't being handled by the tool, and so images were being removed that shouldn't have been:

    ![The Widget tab for an activity
    indicator](progress-indicators-images/activity02.png "The Widget tab for
    an activity indicator")

A high resolution version of the class diagram can be downloaded from [here](class-hierarchy-images/class-diagram-high-resolution.png).

I particularly like the multiple cases of spreading an image link over three lines! Not sure if it's worth the tool handling this. I just fixed the markdown instead. But there were quite a few examples of the second case where an image is actually a download link. In those cases I dropped the images back in place after they were removed. There was also a third case due to writer error on lightbox images (where the images actually rendered fine on learn, despite the markdown being incorrect) - I fixed those.

@davidbritch davidbritch added the bug Something isn't working label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants