Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Formatting Engine Followup #11371

Open
davidwengier opened this issue Jan 9, 2025 · 0 comments
Open

New Formatting Engine Followup #11371

davidwengier opened this issue Jan 9, 2025 · 0 comments

Comments

@davidwengier
Copy link
Contributor

  • OnTypeFormattingPass still uses the old formatting engine, and recompiles Razor files multiple times.
    • It should be possible for that to use the new generated document, and therefore not have to do all of the "cleanup" work after an on-type formatting operation.
    • We'll have to allow the new document generation to track a position in the original document, and map it to the generated document. Regular source mappings won't help here
  • Code actions, snippets and OnAutoInsert have to use the Razor compiler generated document, because they start with edits to that document.
    • Perhaps they could have their own formatting pass, rather than use the OnTypeFormattingPass and all of its cleanup code.

Perf:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant