Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused OverrideBootstrapVersions infrastructure #45550

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

MichaelSimons
Copy link
Member

Fixes dotnet/source-build#3129.

This is old infra that is no longer being used and should be cleaned up.

@MichaelSimons MichaelSimons requested review from a team as code owners December 18, 2024 20:51
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 18, 2024
@MichaelSimons MichaelSimons removed the request for review from a team December 18, 2024 20:51
@ellahathaway
Copy link
Member

The linked issue in dotnet/source-build#3129 (comment) is still open. Does that issue still apply here?

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViktorHofer
Copy link
Member

@MichaelSimons is this ready to merge?

@MichaelSimons
Copy link
Member Author

@MichaelSimons is this ready to merge?

Not yet, I would like to validate a couple things.

@MichaelSimons
Copy link
Member Author

I verified (internal microsoft link) this cleanup in the context of 9.0. This gives me reasonable confidence this is not needed anymore. If we find a case where it is needed, it can easily be added back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OverrideBootstrapVersions.props after 7.0.1 release
3 participants