Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task :d11_react-native-fast-image:compileDebugJavaWithJavac FAILED #39

Closed
nicolaturcoep opened this issue Sep 4, 2024 · 10 comments
Closed
Labels
Impact: Bug Something isn't working

Comments

@nicolaturcoep
Copy link

after command "npm run android"

Task :d11_react-native-fast-image:compileDebugJavaWithJavac FAILED
note: generating mipmap/ic_launcher_round with config "ldpi-v26" for round icon compatibility.
note: generating mipmap/ic_launcher_round with config "mdpi-v26" for round icon compatibility.
note: generating mipmap/ic_launcher_round with config "hdpi-v26" for round icon compatibility.
note: generating mipmap/ic_launcher_round with config "xhdpi-v26" for round icon compatibility.
note: generating mipmap/ic_launcher_round with config "xxhdpi-v26" for round icon compatibility.
note: generating mipmap/ic_launcher_round with config "xxxhdpi-v26" for round icon compatibility.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

@nicolaturcoep nicolaturcoep added the Impact: Bug Something isn't working label Sep 4, 2024
@deepanshushuklad11
Copy link
Contributor

@nicolaturcoep Can you help me more details or a minimum reproducer would be nice

@nicolaturcoep
Copy link
Author

original error was: Task :react-native-fast-image:compileDebugJavaWithJavac

I tried the package as recommended in this thread: DylanVann/react-native-fast-image#1009
but it doesn't solve

my configuration:
"react": "18.3.1",
"react-native": "0.75.2",
"react-native-fast-image": "^8.6.3",

java: openjdk version "17.0.10" 2024-01-16 LTS
gradle: 8.10
node: 21.7.3
npm: 10.8.2

@deepanshushuklad11
Copy link
Contributor

@nicolaturcoep you have used original react-native-fast-image which is not maintained anymore
you should try @d11/react-native-fast-image this is a fork of original repo currently maintained by dream-sports-labs.
We are working on fabric support where we will increase the AGP version , you can track the PR here.

@SebiVPS
Copy link

SebiVPS commented Sep 6, 2024

I also get this error:

Task :d11_react-native-fast-image:compileDebugJavaWithJavac FAILED

Note: [2] Wrote GeneratedAppGlideModule with: [com.bumptech.glide.integration.okhttp3.OkHttpLibraryGlideModule, com.dylanvann.fastimage.FastImageOkHttpProgressGlideModule]

/Users/.../node_modules/@d11/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java:72: error: isResource() in FastImageSource cannot override isResource() in ImageSource
public boolean isResource() {
^
overridden method is final
/Users/.../node_modules/@d11/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java:101: error: getUri() in FastImageSource cannot override getUri() in ImageSource
public Uri getUri() {
^
overridden method is final
2 errors


I updated my project from react-native v0.73.9 to v0.75.2.
I used the original package, where this forked repo comes from before and update to your version but i get the same error in both versions.
Maybe you have an idea whats the problem here?
Thank you for trying to keep this project alive!

Edit:
Also mentioned here: DylanVann/react-native-fast-image#1048
Just saw that there already exists a fix for this issue, maybe you can use that?
DylanVann/react-native-fast-image#1045

@deepanshushuklad11
Copy link
Contributor

I also get this error:

Task :d11_react-native-fast-image:compileDebugJavaWithJavac FAILED

Note: [2] Wrote GeneratedAppGlideModule with: [com.bumptech.glide.integration.okhttp3.OkHttpLibraryGlideModule, com.dylanvann.fastimage.FastImageOkHttpProgressGlideModule]

/Users/.../node_modules/@d11/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java:72: error: isResource() in FastImageSource cannot override isResource() in ImageSource public boolean isResource() { ^ overridden method is final /Users/.../node_modules/@d11/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java:101: error: getUri() in FastImageSource cannot override getUri() in ImageSource public Uri getUri() { ^ overridden method is final 2 errors

I updated my project from react-native v0.73.9 to v0.75.2. I used the original package, where this forked repo comes from before and update to your version but i get the same error in both versions. Maybe you have an idea whats the problem here? Thank you for trying to keep this project alive!

Edit: Also mentioned here: DylanVann/react-native-fast-image#1048 Just saw that there already exists a fix for this issue, maybe you can use that? DylanVann/react-native-fast-image#1045

I wanted to fix this issue , but react-native team already fixed this , which will be released in next version after 0.75.2.
So i am waiting for that

@deepanshushuklad11
Copy link
Contributor

@SebiVPS I would suggest you to try react-native-nightly

@deepanshushuklad11
Copy link
Contributor

@SebiVPS I will fix this within a day or two

@SebiVPS
Copy link

SebiVPS commented Sep 9, 2024

@deepanshushuklad11 Great! Thanks a lot!

@deepanshushuklad11
Copy link
Contributor

@SebiVPS This is fixed , and i have published a new version

@SebiVPS
Copy link

SebiVPS commented Sep 10, 2024

Thank you very much 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants