Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:Create Login and Profile components #9

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat:Create Login and Profile components #9

wants to merge 11 commits into from

Conversation

sambit-sankalp
Copy link
Contributor

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Fixes #6
-> Login Component added
-> Profile Component added

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@netlify
Copy link

netlify bot commented Sep 21, 2021 •
edited
Loading

✔️ Deploy Preview for project-kiwi-og ready!

🔨 Explore the source changes: bc54db2

🔍 Inspect the deploy log: https://app.netlify.com/sites/project-kiwi-og/deploys/6151c3182b7d5d00086bf148

😎 Browse the preview: https://deploy-preview-9--project-kiwi-og.netlify.app

@riteshsp2000
Copy link
Member

@sambit-sankalp

  1. I'm not sure if you have added the styles keeping grids in mind, but the login component is not responsive as of now.
  2. You haven't added the gatsby-plugin-styled-components, which is causing the styles to load later. This results in a small flicker where styles aren't loaded yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DesignrKnight DesignrKnight DesignrKnight left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Login and Profile components
4 participants
@sambit-sankalp @riteshsp2000 @DesignrKnight @abhibhaw