Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: MET maps a polar stereographics projection to the wrong places #3023

Open
23 tasks
hsoh-u opened this issue Nov 15, 2024 · 3 comments
Open
23 tasks

Bugfix: MET maps a polar stereographics projection to the wrong places #3023

hsoh-u opened this issue Nov 15, 2024 · 3 comments
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: input data Input data issue MET: Grid Library Grid and Projection Library Items priority: medium Medium Priority type: bug Fix something that is not working
Milestone

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Nov 15, 2024

Replace italics below with details for this issue.

Describe the Problem

Provide a clear and concise description of the bug here.

The plot_data_plane recognizes the polar stereographics as following from seneca:/d1/personal/jopatz/workbench/tripolar/ice_observation/seaice_conc_daily_nh_1978_v04r00.nc

DEBUG 4: Stereographic Grid Data:
DEBUG 4:   hemisphere: N
DEBUG 4:    scale_lat: 90
DEBUG 4:      lat_pin: 31.0423
DEBUG 4:      lon_pin: 11.6796
DEBUG 4:        x_pin: 0
DEBUG 4:        y_pin: 0
DEBUG 4:   lon_orient: -135
DEBUG 4:         d_km: 25
DEBUG 4:        dy_km: -25
DEBUG 4:         r_km: 6371.2
DEBUG 4:           nx: 304
DEBUG 4:           ny: 448

The recognized parameters for the polar stereographics look OK. But the produced image by plot_data_planne is different from the plot by IDV below.
image
In order to fix this problem, we need more information for the polar stereographics projection (when to apply a negative D_km, etc).

Expected Behavior

Provide a clear and concise description of what you expected to happen here.
The plot by IDV (the image from IDV looks like flipped diagonally or rotated)
image

The adjusted projection with using set_attr_grid="stereo 304 448 31.0423 11.6796 -135 -25 6378.273 90. N"; produces the following images
image
from

./plot_data_plane /d1/personal/jopatz/workbench/tripolar/ice_observation/seaice_conc_daily_nh_1978_v04r00.nc [nccf_polar_ugrid.ps](http://nccf_polar_ugrid.ps/) 'name="cdr_seaice_conc"; level="(0,*,*)"; set_attr_grid="stereo 304 448 31.0423 11.6796 -135 -25 6378.273 90. N";' -v 4

Environment

Describe your runtime environment:
1. Machine: Linux Workstation (seneca)
2. OS: RedHat Linux
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to 'seneca'
2. Find the latest nightly build
3. Run the following command
4. Check the produced image

bin/plot_data_plane /d1/personal/jopatz/workbench/tripolar/ice_observation/seaice_conc_daily_nh_1978_v04r00.nc seaice_polar_projection.ps 'name="cdr_seaice_conc"; level="(0,*,*)";' -v 4

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select MET-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Close this issue.
@hsoh-u hsoh-u added type: bug Fix something that is not working priority: medium Medium Priority alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle reporting: DTC NCAR Base NCAR Base DTC Project component: input data Input data issue MET: Grid Library Grid and Projection Library Items labels Nov 15, 2024
@hsoh-u hsoh-u added this to the MET-12.1.0 milestone Nov 15, 2024
@hsoh-u hsoh-u self-assigned this Nov 15, 2024
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in MET-12.1.0 Development Nov 15, 2024
@michelleharrold michelleharrold removed the reporting: DTC NCAR Base NCAR Base DTC Project label Nov 18, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🟢 Ready in MET-12.1.0 Development Dec 12, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🟢 Ready to 🏗 In progress in MET-12.1.0 Development Dec 12, 2024
hsoh-u pushed a commit that referenced this issue Jan 8, 2025
hsoh-u pushed a commit that referenced this issue Jan 8, 2025
@hsoh-u
Copy link
Collaborator Author

hsoh-u commented Jan 8, 2025

The plot by plot_data_plane does not match with IDV. The plot needs to rotate 180 degrees. The plot by IDV is not correct. I think it's data problem.
Without swaping to north:
image
With swaping to north:
image

@JohnHalleyGotway
Copy link
Collaborator

@hsoh-u notes on Jan 9, 2025, that his proposed fix for this issue causes another existing unit test to break. He'll add details about that with a comment.

@hsoh-u
Copy link
Collaborator Author

hsoh-u commented Jan 16, 2025

The projection information may be not correct.
The projection variable is "crs" at the unit test input file ("NSIDC0081_SEAICE_PS_N25km_20220723_v2.0.nc"). The projection variable is "projection" at the give sample file (seaice_conc_daily_nh_1978_v04r00.nc).
I modified the sample input by using NCO (seaice_conc_daily_nh_1978_v04r00.nc to seneca:/d1/personal/hsoh/data/MET-3023/eaice_conc_daily_nh_1978_v04r00_modified.nc):

  • Added the "crs" variable from the unit test input ("NSIDC0081_SEAICE_PS_N25km_20220723_v2.0.nc")
  • Changed "grid_mapping" attribute at all data variables to "crs" (from "projection")
  • Deleted "projection" variable.

Here is a plot by plot_data_plane after replacing the projection variable:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: input data Input data issue MET: Grid Library Grid and Projection Library Items priority: medium Medium Priority type: bug Fix something that is not working
Projects
Status: 🏗 In progress
Development

No branches or pull requests

4 participants