Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a dtcenter/met-base-metviewer image to make it suitable for METviewer development and testing #23

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Apr 19, 2024 · 0 comments · Fixed by #26
Closed
8 of 21 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue priority: high High Priority requestor: USAF United States Air Force type: new feature Make it do something new

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Apr 19, 2024

Describe the New Feature

Issue dtcenter/METviewer#521 adds automated SonarQube scanning of the METviewer software based on Air Force requirements. This work is done by first building METviewer inside of a Docker container and copying/scanning the resulting distribution files. This approach works well. However, the docker build step takes way too long. The Dockerfiles in METviewer still use centos7 as the base image and build the environment from scratch.

This issue is to update the existing METbaseimage environment so it can be used as the base image for METviewer Docker builds. Note, prior to merging the resulting PR, we should assess whether or not these changes bloat the size of METbaseimage too much. If so, we could consider creating a new METviewerbaseimage instead.

Acceptance Testing

Work on this in conjunction with dtcenter/METviewer#521.
Test that issue using a METbaseimage branch for this feature.

Time Estimate

1-2 days?

Sub-Issues

Consider breaking the new feature down into sub-issues.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added alert: NEED ACCOUNT KEY Need to assign an account key to this issue priority: high High Priority requestor: USAF United States Air Force type: new feature Make it do something new labels Apr 19, 2024
@JohnHalleyGotway JohnHalleyGotway self-assigned this Apr 19, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Update the base image to make it suitable for METviewer development and testing Update the met-base image to make it suitable for METviewer development and testing Apr 19, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Update the met-base image to make it suitable for METviewer development and testing Create a metviewer-base image to make it suitable for METviewer development and testing Jul 3, 2024
@JohnHalleyGotway JohnHalleyGotway linked a pull request Jul 3, 2024 that will close this issue
13 tasks
@JohnHalleyGotway JohnHalleyGotway changed the title Create a metviewer-base image to make it suitable for METviewer development and testing Create a dtcenter/met-base-metviewer image to make it suitable for METviewer development and testing Jul 3, 2024
@georgemccabe georgemccabe mentioned this issue Jul 3, 2024
13 tasks
JohnHalleyGotway added a commit that referenced this issue Jul 3, 2024
JohnHalleyGotway added a commit that referenced this issue Jul 3, 2024
* Per #23, add Dockerfile.metviewer image and update automation to build/push it

* Per #23, update README file with info about #23

* Per #23, remove geos --enable-php configuration option that is not actually supported.

* Per #23 review README
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in METplus-Analysis-6.0.0 Development Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue priority: high High Priority requestor: USAF United States Air Force type: new feature Make it do something new
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants