-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance METviewer to aggregate and plot the HSS_EC statistic from the MCTS line type. #285
Comments
Test data on kiowa |
4 new columns were added to the end of the mcts line type: grid_stat_GRIB1_NAM_STAGE4_120000L_20120409_120000V_mcts.txt |
@JohnHalleyGotway |
@TatianaBurek HSS_EC is computed by this function: To compute it from the MCTC line type, you'll need the counts of NxN table from that line plus the new EC_VALUE value from the last column. The EC_VALUE is a number between 0 and 1. And compute HSS_EC = ( DIAG_COUNT - (EC_VALUE * N) ) / (N - (EC_VALUE * N)) where DIAG_COUNT is the sum of the counts on the diagonal and N is the sum of the counts across the whole MCTC table. |
@JohnHalleyGotway DIAG_COUNT = (i_value=1, j_valye=1) +(i_value=2, j_valye=2)+ (i_value=3, j_valye=3)+(i_value=4, j_valye=4) =49519+19+32+0 ??? |
@TatianaBurek yes, you've got it exactly right. DIAG_COUNT is the sum of counts where i == j and N is the sum of all counts. Assuming EC_VALUE = 0.25 for this line, we'd have:
|
@JohnHalleyGotway |
@TatianaBurek, yes, when aggregating multiple MCTC lines together, I do think it makes sense to require that N_CAT remain constant across the input lines. In fact, I expect that typically, the actual thresholds listed in the FCST_THRESH and OBS_THRESH columns would also remain constant. However, if we're not enforcing that requirement in the aggregation of PCT lines, let's not enforce it when aggregating MCTC lines either. If the script already has the FCST_THRESH and OBS_THRESH columns available to it, you could add a check to see if the string remain constant (separate for FCST_THRESH and OBS_THRESH). And if not, print a warning message to the plot log file about that. When N_CAT changes while aggregating MCTC lines, Stat-Analysis prints the following type of error message:
But if the list of thresholds change while N_CAT remains constant, you only get warning messages, like this:
|
@JohnHalleyGotway |
The exact same aggregation vs summary logic that we use for CTC counts/CTS stats, and for SL1L2 sums/CNT stats, and for PCT counts/PSTD stats applies here. The "summary" method for HSS_EC would be to compute the stat separately for each input line and then report the mean or median of those scores, based on the user configuration. The "aggregation" method would be to first aggregate those multiple MCTC lines into one large one, and the derive a single aggregated HSS_EC statistic. The MCTC aggregation logic is exactly the same as what we do for CTC and PCT... just sum up each cell of the table as well as the TOTAL count. The same logic should apply to any of the other MCTS statistics that METviewer is serving up. |
I only have a formula for HSS_EC. |
The other MCTS stats can be found in:
https://met.readthedocs.io/en/latest/Users_Guide/point-stat.html#id13
The MCTS stats that *could* be added are ACC, HK, HSS, and GER. Since we're
adding HSS_EC for this issue, it does seem like we should add HSS. ACC is
very easy (just the percent of counts on the diagonal), but the computation
of HK, HSS, and GER are much less so.
This definitely would be scope creep for this issue. One option would be
adding HSS_EC and HSS here, and write up another issue for adding the
others. But I'd recommend talking to Tara to prioritize that work in the
context of other tasks.
FYI, the code which computes these stats can be found in this file:
https://github.com/dtcenter/MET/blob/main_v10.0/met/src/libcode/vx_statistics/contable_stats.cc
…On Thu, Jul 22, 2021 at 8:17 AM Tatiana Burek ***@***.***> wrote:
I only have a formula for HSS_EC.
What are other stats and how to calculate them?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#285 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFA4HKCYALMZNFJPNQ77LATTZASAPANCNFSM46KMK4HQ>
.
|
I created a separate issue related to the adding other stats: |
We're not enforcing the requirement of FCST_THRESH and OBS_THRESH columns being constant in the aggregation of PCT lines so I do not enforce it when aggregating MCTC lines either. |
Describe the Enhancement
Heidke Skill Score is being updated to accommodate CPC needs. The MCTS line type in MET version 10.1.0 will include two new columns, HSS_EC and EC_VALUE. The EC_VALUE column may also be added to the MCTC line type to avoid making the EC_VALUE a new required configuration option.
MET issue to generate new statistics: dtcenter/MET#1749
METdatadb loader issue: dtcenter/METdataio#54
METviewer should be enhanced to plot the HSS_EC statistic in the exact same way that the existing MCTS:HSS statistics is handled.
Will also need to enhance METcalcpy to updated the MCTC to MCTS aggregation logic:
Corresponding issue in METcalcpy:
dtcenter/METcalcpy#107
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 3days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
The text was updated successfully, but these errors were encountered: