Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] password complexity check when registering #1894

Open
bogusbd opened this issue Jan 14, 2025 · 3 comments
Open

[BUG] password complexity check when registering #1894

bogusbd opened this issue Jan 14, 2025 · 3 comments

Comments

@bogusbd
Copy link

bogusbd commented Jan 14, 2025

Hello,

Password complexity is not checked when registering, but when entering OTP it is checked and I get an error:

0:["$@1",["LcysgsUh_M6A-tjDh0BnZ",null]]
1:{"validationErrors":{"password":["Password must contain at least one number, one uppercase, and one lowercase letter"]}}

visible in API request but not in interface

This error is reproducible on dub.co.
Perhaps it was fixed in the main branch.

Copy link

linear bot commented Jan 14, 2025

@bogusbd bogusbd changed the title BUG: password complexity check [BUG] password complexity check Jan 14, 2025
@bogusbd bogusbd changed the title [BUG] password complexity check [BUG] password complexity check when registering Jan 14, 2025
@Dyuti01
Copy link

Dyuti01 commented Jan 15, 2025

Hey @styfle and @devkiran I want to work on this bug, please assign me this task.
The bug is because during signup only the "email" is sent as payload and not the password so zod is not finding any password to validate.
I fixed the above bug and also fixed the toast messages for zod-invalid passwords and emails.
I am going to create a PR for this.

@Dyuti01
Copy link

Dyuti01 commented Jan 15, 2025

#1904 This is my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants