Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork sisyphus and maintain #2371

Open
hansegucker opened this issue Jan 13, 2025 · 3 comments
Open

Fork sisyphus and maintain #2371

hansegucker opened this issue Jan 13, 2025 · 3 comments

Comments

@hansegucker
Copy link
Collaborator

hansegucker commented Jan 13, 2025

While implementing #1575, I discovered that sisyphus is broken and isn't maintained since seven years. As the source code is only 550 lines long and we could save some more lines by dropping unnecessary stuff, I would suggest to take the source code, drop the jQuery dependency and maintain it as .ts file in our source.

@hansegucker
Copy link
Collaborator Author

@richardebeling @niklasmohrin @Kakadus Would be great to get an opinion.

@richardebeling
Copy link
Member

Generally open to it, but I'm afraid without jquery it would be a bit more code -- if there's a way where we don't add more maintenance overhead, I'd prefer that :D

How is it broken -- anything we need to fix?

@niklasmohrin
Copy link
Member

I think it would be nice to have it in our repo for up to 200, maybe 300 lines of code. The original code has lengthy comments and support for some weird editor, I feel that it should be doable with modern browser APIs and typescript features in ~200 lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants