From ca77e35f5c7b6643c361cc6b2840d2f8254c7115 Mon Sep 17 00:00:00 2001
From: ecCinziaMazzetti <39341585+ecCinziaMazzetti@users.noreply.github.com>
Date: Mon, 11 Nov 2024 12:26:28 +0000
Subject: [PATCH] Feature/channel param (#177)

* added parameters for calibration of channels geometry

* fixing sintax error

---------

Co-authored-by: Cinzia Mazzetti <mocm@ecmwf.int>
---
 src/lisflood/hydrological_modules/routing.py | 14 ++++++++++----
 src/lisfloodSettings_reference.xml           |  6 +++---
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/lisflood/hydrological_modules/routing.py b/src/lisflood/hydrological_modules/routing.py
index a44e6d7b..9268de83 100644
--- a/src/lisflood/hydrological_modules/routing.py
+++ b/src/lisflood/hydrological_modules/routing.py
@@ -46,7 +46,8 @@ class routing(HydroModule):
     """
     input_files_keys = {'all': ['beta', 'ChanLength', 'Ldd', 'Channels', 'ChanGrad', 'ChanGradMin',
                                 'CalChanMan', 'ChanMan', 'ChanBottomWidth', 'ChanDepthThreshold',
-                                'ChanSdXdY', 'TotalCrossSectionAreaInitValue', 'PrevDischarge'],
+                                'ChanSdXdY', 'TotalCrossSectionAreaInitValue', 'PrevDischarge',
+                                'ChanBottomWMult', 'ChanDepthTMult', 'ChanSMult'],
                         'SplitRouting': ['CrossSection2AreaInitValue', 'PrevSideflowInitValue', 'CalChanMan2'],
                         'dynamicWave': ['ChannelsDynamic'],
                         'MCTRouting': ['ChannelsMCT', 'ChanGradMaxMCT', 'PrevCmMCTInitValue', 'PrevDmMCTInitValue','CalChanMan3']}
@@ -214,11 +215,16 @@ def initial(self):
         self.var.ChanMan = self.var.CalChanMan * loadmap('ChanMan')
         # Manning's roughtness coefficient n is multiplied by ChanManCal for calibration
 
-        self.var.ChanBottomWidth = loadmap('ChanBottomWidth')
+        self.var.CalChanBottomWidth = loadmap('ChanBottomWMult')
+        self.var.ChanBottomWidth = self.var.CalChanBottomWidth * loadmap('ChanBottomWidth')
         # Riverbed width [m]
-        ChanDepthThreshold = loadmap('ChanDepthThreshold')
+
+        self.var.CalChanDepthThreshold = loadmap('ChanDepthTMult')
+        ChanDepthThreshold = self.var.CalChanDepthThreshold * loadmap('ChanDepthThreshold')
         # Bankfull river depth [m]
-        self.var.ChanSdXdY = loadmap('ChanSdXdY')
+
+        self.var.CalChanSdXdY= loadmap('ChanSMult')
+        self.var.ChanSdXdY = self.var.CalChanSdXdY * loadmap('ChanSdXdY')
         # Riverbed sides slope
 
         # self.var.ChanSdXdY = maskinfo.in_zero()         # rectangular cross-section
diff --git a/src/lisfloodSettings_reference.xml b/src/lisfloodSettings_reference.xml
index 9eda0bd5..79d50e77 100644
--- a/src/lisfloodSettings_reference.xml
+++ b/src/lisfloodSettings_reference.xml
@@ -484,20 +484,20 @@ Multiplier applied to average Q to split into a second line of routing
 </comment>
 </textvar>
 
-<textvar name="ChanBottomWMult" value="1.0">
+<textvar name="ChanBottomWMult" value="$(PathParams)/params_ChanBottomWMult">
 <comment>
 PBchange
 Multiplier applied to ChanBottomWidth
 </comment>
 </textvar>
 
-<textvar name="ChanDepthTMult" value="1.0">
+<textvar name="ChanDepthTMult" value="$(PathParams)/params_ChanDepthTMult">
 <comment>
 Multiplier [] applied to ChanDepthThreshold
 </comment>
 </textvar>
 
-<textvar name="ChanSMult" value="1.0">
+<textvar name="ChanSMult" value="$(PathParams)/params_ChanSMult">
 <comment>
 Multiplier []  applied to ChanSdXdY
 </comment>