Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup build tooling and avoid in-repo binaries under test #290

Open
lefou opened this issue Mar 2, 2024 · 0 comments
Open

Cleanup build tooling and avoid in-repo binaries under test #290

lefou opened this issue Mar 2, 2024 · 0 comments

Comments

@lefou
Copy link
Contributor

lefou commented Mar 2, 2024

There are some binaries checked-in which can easily get out of date resulting in potential misleading test results. Those may result in regressions like #285.

@kriegaex posted in #289 (comment)

I am aware of that. I am simply in a tight spot concerning the time at my disposal. The actual problem is that this stuff was ever checked into the SCM in the first place. I eliminated lots of these relics already since I joined the project. These are a bit difficult, because the tests run before the main AspectJ build artifacts (runtime, matcher, weaver, tools) are being built, i.e. we have a circular dependency there. In the future, I will rather spend time fixing the root cause than automating the workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant