Parallel API Analysis: IllegalStateException: The bundle belongs to another state

[jukzi]

java.lang.IllegalStateException: The bundle belongs to another state: org.eclipse.help_3.10.200.v20231106-1240
	at org.eclipse.osgi.internal.resolver.StateImpl.basicAddBundle(StateImpl.java:734)
	at org.eclipse.osgi.internal.resolver.StateImpl.addBundle(StateImpl.java:199)
	at org.eclipse.pde.api.tools.internal.model.ApiBaseline.addApiComponents(ApiBaseline.java:414)
	at org.eclipse.pde.api.tools.internal.model.ApiBaseline.restoreFrom(ApiBaseline.java:800)
	at org.eclipse.pde.api.tools.internal.ApiBaselineManager.loadBaselineInfos(ApiBaselineManager.java:249)
	at org.eclipse.pde.api.tools.internal.model.ApiBaseline.loadBaselineInfos(ApiBaseline.java:772)
	at org.eclipse.pde.api.tools.internal.model.ApiBaseline.getApiComponent(ApiBaseline.java:731)
	at org.eclipse.pde.api.tools.internal.builder.BaseApiAnalyzer.analyzeComponent(BaseApiAnalyzer.java:239)
	at org.eclipse.pde.api.tools.internal.builder.ApiAnalysisBuilder.buildAll(ApiAnalysisBuilder.java:917)
	at org.eclipse.pde.api.tools.internal.builder.ApiAnalysisBuilder.work(ApiAnalysisBuilder.java:402)
	at org.eclipse.pde.api.tools.internal.builder.ApiAnalysisBuilder$ApiAnalysisJob.run(ApiAnalysisBuilder.java:554)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

eclipse.buildId=4.31.0.I20240131-1800
java.version=21.0.2

@iloveeclipse i mark this as regression, as there is currently no workaround anymore to disable parallel execution

[iloveeclipse]

there is currently no workaround anymore to disable parallel execution

One can add Preferences.MainPage.runAPIAnalysisAsJob=true to <workspace>/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.pde.core.prefs file.

But actually we simply should restore the possibility to change the preference from UI. If you can find that commit, please revert & push PR.

[laeubi]

Maybe better make the job / analysis more robust? Running it not as a job has major performance impact

[iloveeclipse]

Maybe better make the job / analysis more robust?

Sure, I was only mentioning possibility to configure it in a more convenient way.

Please be aware, PDE code is a nightmare of synchronization problems, it is like a can of worms...

[iloveeclipse]

One of the problems is the baseline management with where baselines are updated / disposed on the fly, they are not atomic as of today.

[jukzi]

was removed with #307

[jukzi]

closing as parallel analysis is no default anymore