Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APITools] Handle multiple version correct when obtaining prerequisites #1339

Merged

Conversation

HannesWell
Copy link
Member

ApiBaseline.getPrerequisiteComponents() didn't consider multiple versions of a component.
Besides fixing that, this also unifies and simplifies the handling of multiple versions.

I noticed that while working on #1336.

Copy link

github-actions bot commented Jul 13, 2024

Test Results

   285 files  ±0     285 suites  ±0   49m 18s ⏱️ -53s
 3 586 tests ±0   3 510 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 950 runs  ±0  10 719 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit a4d95f8. ± Comparison against base commit 0c0b31a.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Contributor

laeubi commented Jan 10, 2025

@HannesWell should we merge this to get some confidence nothing is broken?

ApiBaseline.getPrerequisiteComponents() didn't consider multiple
versions of a component.
Besides fixing that, this also unifies and simplifies the handling of
multiple versions.
@HannesWell HannesWell force-pushed the api-tools-handle-multiple-versions branch from 770c2a2 to a4d95f8 Compare January 10, 2025 17:58
@HannesWell
Copy link
Member Author

@HannesWell should we merge this to get some confidence nothing is broken?

Locally I couldn't fully test this, but I'm fine trying this out.

@laeubi laeubi merged commit 79b126c into eclipse-pde:master Jan 13, 2025
18 checks passed
@HannesWell HannesWell deleted the api-tools-handle-multiple-versions branch January 13, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants