Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance httpclientjava provider to use SSLContext created on ECF startup #134

Closed
scottslewis opened this issue Nov 16, 2024 · 1 comment
Closed

Comments

@scottslewis
Copy link
Contributor

Currently, a customized/customizable SSLContext is created on ECF startup, in org.eclipse.ecf core bundle startup (via fragment org.eclipse.ecf.ssl).

Unlike previous providers, the httpclientjava provider must be passed the SSLContext instance (rather than the SSLSocketFactory) via the HttpClient.Builder during HttpClient instance construction.

@scottslewis
Copy link
Contributor Author

With pr #138 I've introduced a new osgi service, represented by the service interface class SSLContextFactory this service...available to all ECF filetransfer providers, allows the setting of the provider SSLContext with the implementation of service methods provided by the implementation of the service, rather than through the static methods: SSLContext.getDefault(), SSLContext.getInstance(String) and SSLContext.getInstance(String,String).

The (first) use of this service is in the httpclientjava provider here

This provides flexibility to support needs of httpclientjava provider (and other providers as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant