Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show number of results to a filtered search #233

Open
ZachSGold opened this issue May 14, 2015 · 8 comments
Open

Show number of results to a filtered search #233

ZachSGold opened this issue May 14, 2015 · 8 comments
Labels
ready-to-deploy

Comments

@ZachSGold
Copy link

No description provided.

@aslagle
Copy link
Contributor

aslagle commented May 18, 2015

How about changing the "Show X rows per page" to "Show X of Y rows"

@ZachSGold
Copy link
Author

@aslagle I think that is a good idea.

@jgoley
Copy link
Contributor

jgoley commented May 18, 2015

@aslagle is this feasible without changing the package?

@aslagle
Copy link
Contributor

aslagle commented May 18, 2015

No, it has to be in the package.

@ZachSGold ZachSGold added ready and removed ready labels Jun 4, 2015
@aslagle aslagle added this-week and removed ready labels Jun 16, 2015
@jgoley
Copy link
Contributor

jgoley commented Jun 17, 2015

Just created a pull request on the reactive-table repo: aslagle/reactive-table#231

@aslagle
Copy link
Contributor

aslagle commented Jun 28, 2015

@jgoley - this is merged in reactive-table, version 0.8.2. Please make a PR for the version update and any other changes we need for this.

@jgoley jgoley mentioned this issue Jun 29, 2015
Merged
@jgoley jgoley assigned aslagle and unassigned jgoley Jul 6, 2015
@ZachSGold
Copy link
Author

@aslagle Did this get completed? It isn't essential and could be moved to the backlog.

@aslagle
Copy link
Contributor

aslagle commented Aug 28, 2015

Yes, that should be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready-to-deploy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aslagle @jgoley @ZachSGold