Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation ambiguity for {{- appName}} #2689

Open
gautierchomel opened this issue Dec 3, 2024 · 3 comments
Open

Localisation ambiguity for {{- appName}} #2689

gautierchomel opened this issue Dec 3, 2024 · 3 comments
Labels

Comments

@gautierchomel
Copy link
Member

{{- appName}} seems to be used to name different pieces

There, it clearly refers to the App Name (Thorium)

  • error.errorBox.title | Internal {{- appName}} Error
  • app.hide | Hide {{- appName}}
  • app.quit | Quit {{- appName}}
  • app.update.title | {{- appName}} software update.

But here, it seems to be used for the book title

  • catalog.about.title | About {{- appName}}

That makes the localisation difficult.

@arthur-lemeur
Copy link
Collaborator

The "catalog.about.title" refers to the footer of the application, it is the "About Thorium" link leading to the documentation.

Capture d’écran 2024-12-05 à 16 33 08

@gautierchomel
Copy link
Member Author

Thanks for the clarification.
We should clarify that this is not the documentation but a legacy about file.

@gautierchomel
Copy link
Member Author

Also, would it be complicated to rename that key app.about for consistency with other App related keys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants