Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations lists are not tagged as semantic list #2729

Open
gautierchomel opened this issue Dec 19, 2024 · 2 comments · May be fixed by #2705
Open

Annotations lists are not tagged as semantic list #2729

gautierchomel opened this issue Dec 19, 2024 · 2 comments · May be fixed by #2705
Labels
accessibility

Comments

@gautierchomel
Copy link
Member

The annotation panels display annotations as a list, but they are not semantically identified.

screenshot with code: <div class="annotations_line" style="border-left: 4px solid rgb(212, 196, 251);"><div class="annnotation_container"><button class="annotation_name R2_CSS_CLASS__FORCE_NO_FOCUS_OUTLINE" aria-label="Go to ... &quot;Solid background&quot;" id="9c7f444f-f52a-4616-aebc-8613c5607a1c"><p>Solid background</p></button><p><span></span><br></p></div><div class="annotation_edit"><div><div><svg aria-hidden="true" viewBox="0 0 14 14"><use xlink:href="#calendar-icon"></use></svg><p>19/12/2024</p></div><div><svg aria-hidden="true" viewBox="0 0 14 13"><use xlink:href="#bookOpen-icon"></use></svg><p>59% </p></div></div><div class="annotation_actions_buttons"><button id="annotation_card-9c7f444f-f52a-4616-aebc-8613c5607a1c_edit_button" title="Edit"><svg aria-hidden="true" viewBox="0 0 11 11"><use xlink:href="#pen-icon"></use></svg></button><button title="Delete" type="button" aria-haspopup="dialog" aria-expanded="false" aria-controls="radix-:r16v:" data-state="closed"><svg aria-hidden="true" viewBox="0 0 16 18"><use xlink:href="#trash-icon"></use></svg></button></div></div><div class="gauge"><div class="fill" style="width: 58.99%;"></div></div></div>
@gautierchomel
Copy link
Member Author

As a consequence, screen reader users cannot know how many annotations are present nor list them.

@gautierchomel
Copy link
Member Author

This also applies to Bookmarks.

@arthur-lemeur arthur-lemeur linked a pull request Dec 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix accessibility edrlab/thorium-reader
1 participant
@gautierchomel