-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential Trojan in electron builder uninstaller. #4878
Comments
Could you run a scan on virustotal and post the results here? https://www.virustotal.com/gui/home This would provide some pretty critical information about whether this is legit or a false positive. |
False positive, until MS Defender is not fixed, NSIS version was reverted. Please try 22.5.1 |
undergroundwires
added a commit
to undergroundwires/privacy.sexy
that referenced
this issue
Feb 27, 2022
Microsoft Defender considers the uninstaller virus. It's a false-psoitive caused by `electron-builder` used to build NSIS package. This commit solves the issue by explicitly adding `electron-builder` as dependency. This way, `vue-cli-plugin-electron-builder` always resolves to the desired version. Now the version used for `electron-builder` is more controlled. New uninstaller generated by latest specified patch does not trigger an alert, which solves the false-positive issue. See also : - electron-userland/electron-builder#4793, - electron-userland/electron-builder#4878.
undergroundwires
added a commit
to undergroundwires/privacy.sexy
that referenced
this issue
Feb 27, 2022
Microsoft Defender considers the uninstaller virus. It's a false-psoitive caused by `electron-builder` used to build NSIS package. This commit solves the issue by explicitly adding `electron-builder` as dependency. This way, `vue-cli-plugin-electron-builder` always resolves to the desired version. Now the version used for `electron-builder` is more controlled. New uninstaller generated by latest specified patch does not trigger an alert, which solves the false-positive issue. See also: - electron-userland/electron-builder#4793, - electron-userland/electron-builder#4878.
LarrMarburger
pushed a commit
to LarrMarburger/privacy.sexy
that referenced
this issue
Nov 16, 2023
Microsoft Defender considers the uninstaller virus. It's a false-psoitive caused by `electron-builder` used to build NSIS package. This commit solves the issue by explicitly adding `electron-builder` as dependency. This way, `vue-cli-plugin-electron-builder` always resolves to the desired version. Now the version used for `electron-builder` is more controlled. New uninstaller generated by latest specified patch does not trigger an alert, which solves the false-positive issue. See also: - electron-userland/electron-builder#4793, - electron-userland/electron-builder#4878.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
22.4.1
There seems to be a code signing issue in Windows while using pfx certificate as described in this issue #4383
Apparently it is only a problem when using electron-builder version
22.4.1
.What's more, only in this version do I get a Windows Security Notification whenever I try to build. It seems Windows is finding a Trojan and therefore interferes with the signing process. Not sure when is a false positive or not. Or only with my system or not.
But I do not get any such errors with the previous major build.
The text was updated successfully, but these errors were encountered: