Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux AppImage update unable to move downloaded file #8698

Closed
flexopticalHenno opened this issue Nov 20, 2024 · 3 comments · Fixed by #8802
Closed

Linux AppImage update unable to move downloaded file #8698

flexopticalHenno opened this issue Nov 20, 2024 · 3 comments · Fixed by #8802

Comments

@flexopticalHenno
Copy link

  • Electron-Builder Version: 25.0.4 (also 25.1.7 / 25.1.8)
  • Node Version: 20.16.0 / 18.20.5
  • Electron Version: 32.1.2 / 32.2.5
  • Electron Type (current, beta, nightly): current
  • Electron-Updater Version: 6.3.3 (also 6.3.9)
  • Target: AppImage

Building the app works fine, but when the app finds an update, it downloads it to the cache folder, removes the old AppImage and then fails to move the downloaded file to the original AppImage location. The error states (translated) "mv: Executing stat not possible for '/home/username/.cache/app-name-updater/pending/APP Name.1.2.3-latest.4.AppImage': File not found". Copying the failed command into a terminal moves that file successfully.

Stack trace includes AppImageUpdater.doInstall in AppImageUpdater:88:42 and AppImageUpdater.install in BaseUpdater.js:61:25 and AppImageUpdater.quitAndInstall in BaseUpdater.js:15:34

The app name contains spaces, so the issue may be related to the fix that was introduced in 1c14820

The update was still working with electron-builder 25.0.3 and electron-updater 6.3.2. Tested on Ubuntu 24.04 and Debian 12 VMs.
@beyondkmp
Copy link
Collaborator

This should be caused by

electron-builder/packages/electron-updater/src/AppImageUpdater.ts

Line 96 in 6a6bed4

execFileSync("mv", ["-f", options.installerPath, destination])

@beyondkmp beyondkmp mentioned this issue Nov 23, 2024
Closed
@pierremtb pierremtb mentioned this issue Nov 25, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jan 22, 2025
@flexopticalHenno
Copy link
Author

I don't consider this issue to be stale because the linked pull-request is not merged or released yet

@github-actions github-actions bot removed the Stale label Jan 23, 2025
erijo added a commit to erijo/electron-builder that referenced this issue Jan 24, 2025
@erijo
fix(linux): AppImage update when filename contains spaces
6909260 
Revert move of space escape to BaseUpdater (from electron-userland#8403) and instead do
it separately in DebUpdater, PacmanUpdater and RpmUpdater as this escape
breaks AppImageUpdater. Fixes electron-userland#8698.
erijo added a commit to erijo/electron-builder that referenced this issue Jan 24, 2025
@erijo
fix(linux): AppImage update when filename contains spaces
8fa1516 
Revert move of space escape to BaseUpdater (from electron-userland#8403) and instead do
it separately in DebUpdater, PacmanUpdater and RpmUpdater as this escape
breaks AppImageUpdater. Fixes electron-userland#8698.
@erijo erijo mentioned this issue Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@beyondkmp @flexopticalHenno