org.epics.pvaccess.server.impl.remote.handlers.CreateChannelHandler

[ralphlange]

@mrkraimer opened this issue on Jun 29, 2016:

ChannelRequesterImpl does not implement channelStateChange

...
public void channelStateChange(Channel c, ConnectionState isConnected) {
// noop
}
...

This should send the channelStateChange to the client.

@msekoranja commented on Aug 17, 2016:

Message should not be send directly to the client. When DISCONNECTED/CLOSED state is received it should destroy the channel and send message. See C++ code:

void ServerChannelRequesterImpl::channelStateChange(Channel::shared_pointer const & /*channel*/, const Channel::ConnectionState isConnected)
{
    if(isConnected==Channel::CONNECTED || isConnected==Channel::NEVER_CONNECTED)
        return;

    if(Transport::shared_pointer transport = _transport.lock())
    {
        ChannelHostingTransport::shared_pointer casTransport = dynamic_pointer_cast<ChannelHostingTransport>(transport);
        if (!casTransport)
            return;

        ServerChannelImpl::shared_pointer channel;
        {
            Lock guard(_mutex);
            channel= dynamic_pointer_cast<ServerChannelImpl>(_serverChannel.lock());
        }

        if (!channel)
            return;

        // destroy
        channel->destroy();

        // .. and unregister
        casTransport->unregisterChannel(channel->getSID());

        // send response back
        TransportSender::shared_pointer sr(new ServerDestroyChannelHandlerTransportSender(channel->getCID(), channel->getSID()));
        transport->enqueueSendRequest(sr);
    }
}