Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose remoteTransportRevision #15

Closed
mdavidsaver opened this issue Mar 22, 2018 · 1 comment
Closed

expose remoteTransportRevision #15

mdavidsaver opened this issue Mar 22, 2018 · 1 comment

Comments

@mdavidsaver
Copy link

Right now nothing is done with the peer's reported protocol version number. Transport.getRevision() is always returning PVAConstants.PVA_PROTOCOL_REVISION when it should be returning the lesser of this or remoteTransportRevision.

So far, monitor flow control messages have been conditional on a pvRequest option 'record._options.pipeline'.
This requires the client to implicitly know if the server supports this protocol feature.
I'm planning to make monitor flow control messages mandatory, and to use a minor version increment to signal this in a backwards compatible way.

@ralphlange
Copy link
Contributor

Copied over issue to its new place.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants