Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write in README how to push the notifier image to auroradev and auroraprod acrs #78

Open
tsundvoll opened this issue Dec 20, 2024 · 1 comment
Assignees

Comments

@tsundvoll
Copy link
Collaborator

Describe the improvement you would like to see
We will not have a dedicated workflow for this, since updates to the image is anticipated to be rearer. Instead, document in the README how to push manually

How will this change existing functionality?
NA

How will this improvement affect the current Threat Model?
NA

@olaals
Copy link
Contributor

olaals commented Dec 23, 2024

I have added that notifier image is pushed automatically.
The dev image tag does not depend on the commit, but is rather a hash based on the files that exist under the workflow-notifier directory.

If there is not changes to any files under the workflow-notifier, the same hash will be generated.

It still pushes the same image to the ACR. If we can find a way to skip this pushing if the image with the tag already exists in the acr it would be a small improvement.

Now it overwrites the image with the same image, which is fine, but not really necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants