Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐈 Task: Drop support for Python 3.7 #1226

Closed
2 tasks
DhanshreeA opened this issue Aug 13, 2024 · 8 comments
Closed
2 tasks

🐈 Task: Drop support for Python 3.7 #1226

DhanshreeA opened this issue Aug 13, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@DhanshreeA
Copy link
Member

DhanshreeA commented Aug 13, 2024

Summary

Python 3.7 is officially dropped from many packages that Ersilia depends on or makes use of in some capacity. The pressing one currently is poetry which now does not build with Python 3.7 and packages built with it may or may not work with Python 3.7 either.

Objective(s)

  • Figure out what changes need to be made for dropping this support
  • Removing tests concerned with Python 3.7

Documentation

No response

@GemmaTuron
Copy link
Member

Hi @DhanshreeA

Is this linked to #944 ? When one is updated please reflect here as well

@DhanshreeA
Copy link
Member Author

DhanshreeA commented Sep 23, 2024

Required updates:

  1. pyproject.toml needs updating for this in a few places, such as dependencies (validators, sphinx), and in Classifiers (ie supported Python versions)
  2. In the tests_and_cleanup.yml workflow, install-ersilia, and test-docker jobs can do away with accounting for Python 3.7

@GemmaTuron GemmaTuron moved this to On Hold in Ersilia Model Hub Sep 24, 2024
@DhanshreeA DhanshreeA added the good first issue Good for newcomers label Oct 5, 2024
@DhanshreeA DhanshreeA removed their assignment Oct 5, 2024
@DhanshreeA DhanshreeA moved this from On Hold to Queued in Ersilia Model Hub Oct 5, 2024
@P-Mefut
Copy link

P-Mefut commented Oct 5, 2024

hi @DhanshreeA I'll love to give this a go

@Darkbeast-glitch
Copy link
Contributor

HI @DhanshreeA I would love to take this issue. thank you

@DhanshreeA
Copy link
Member Author

@P-Mefut and @Darkbeast-glitch - let me review your existing PRs first, then we can consider this! Thanks!

@DhanshreeA
Copy link
Member Author

@Darkbeast-glitch I don't see you assigned to any issue, my bad. Please take up this one.

@Darkbeast-glitch
Copy link
Contributor

@Darkbeast-glitch I don't see you assigned to any issue, my bad. Please take up this one.

@DhanshreeA Thank you ma . will work on that.

@DhanshreeA DhanshreeA moved this from Queued to In Progress in Ersilia Model Hub Oct 13, 2024
@DhanshreeA
Copy link
Member Author

Addressed in #1316

@github-project-automation github-project-automation bot moved this from In Progress to Done in Ersilia Model Hub Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

4 participants