Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Test for CatalogTable.as_json #1319 #1335

Closed
wants to merge 25 commits into from

Conversation

KimFarida
Copy link
Contributor

@KimFarida KimFarida commented Oct 18, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

This PR introduces a new test suite for the as_json method of the CatalogTable class, ensuring accurate conversion of catalog data to JSON format. The tests verify data integrity and structure, validating that the output matches the expected format and contents.

Changes to be made

  • Added a new directory inputs/test_catalog containing test_catalog.json, which serves as sample input data for testing.
    Implemented a test function, test_as_json, to:
    • Confirm the output of as_json is a valid JSON string.
    • Validate the parsed result maintains the correct structure and data integrity.
    • Handle scenarios with standard and empty catalog data, ensuring appropriate output for both cases.

Status

Replace this line with what you have done so far...

To do

If this is a work in progress, Replace this line with your next steps

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID

Related to #1319

@miquelduranfrigola
Copy link
Member

@DhanshreeA are we on top of this?

@KimFarida
Copy link
Contributor Author

@DhanshreeA are we on top of this?

Hi! . There are actually two more tests to add, but seeing as @DhanshreeA hadn't reviewed my PR on the first two, I wasn't sure if to proceed.

@DhanshreeA
Copy link
Member

closing because too many conflicts.

@DhanshreeA DhanshreeA closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants