-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Test for CatalogTable.as_json #1319 #1335
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DhanshreeA are we on top of this? |
Hi! . There are actually two more tests to add, but seeing as @DhanshreeA hadn't reviewed my PR on the first two, I wasn't sure if to proceed. |
closing because too many conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
This PR introduces a new test suite for the
as_json
method of theCatalogTable
class, ensuring accurate conversion of catalog data to JSON format. The tests verify data integrity and structure, validating that the output matches the expected format and contents.Changes to be made
inputs/test_catalog
containingtest_catalog.json,
which serves as sample input data for testing.Implemented a test function, test_as_json, to:
Status
Replace this line with what you have done so far...
To do
If this is a work in progress, Replace this line with your next steps
Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
Related to #1319