-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Improvement on the Airtable Interface(#1299) #1343
Conversation
This reverts commit 90f0551.
Thanks @Abellegese |
Yes @miquelduranfrigola, on the first pull that you merged, I improve 120,000x time the json based model searching functions so this one is just an alternative. Thanks. |
@DhanshreeA let's merge this (or whatever further development you've done) as soon as all is ready. |
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
A few improvement made on the airtable interface as listed below:
Changing manual yield with more efficient and auto sub-generator creator yield from
In terms of performance, yield from can be more efficient than manually using yield with a loop. This is because yield from is implemented in C and optimized to handle delegation more efficiently and also has memory improvement. Will report time comparison on the 🐕 Batch: Ersilia CLI Performance Improvement #1299.
Using pyairtable is inevitable so instead of installing it during AirtableInterface call, we can install it as requirements(in pyproject.toml), that reduce the AirtableInterface overhead.
Related to #1299