Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐈 Task: Revise resolution method for Dockerized images in models #1509

Open
4 tasks
DhanshreeA opened this issue Jan 15, 2025 · 2 comments
Open
4 tasks

Comments

@DhanshreeA
Copy link
Member

Summary

Presently we determine the packing method of a model's image using this utility function, which looks at the history of the docker image and determines how the image was created based on the kinds of commands that were run in the image layers during its creation.

This is turning out to be an unreliable solution as on some users' machines, the image's history appears to be different, despite the image being entirely the same (as we can verify from its SHA256 value). Therefore, we have decided to add another metadata field to models called Docker Pack Method which we intend to utilise instead of reading the image's history to resolve the image's pack method.

This information can be easily collected and stored in our metadata stores as part of our workflows. And utilising this would make ersilia a lot more reliable and not cause perfectly working models to randomly break every now and then.

Objective(s)

  • Update the Docker Pack Method column in the Airtable database for all models.
  • Update the referenced function to read the metadata. In fact the function can be deleted, and we can potentially add a method in the BaseInformation class.
  • Update the model build workflows to capture this information.
  • Update airtableops.py module to add this information into Airtable, which will then be naturally serialized to the S3 JSON as well.

Documentation

No response

@DhanshreeA
Copy link
Member Author

@GemmaTuron this should take care of what you're experiencing here: ersilia-os/eos3b5e#15 (comment)

@DhanshreeA
Copy link
Member Author

Part of updating the workflows will be addressed in the #1484

@DhanshreeA DhanshreeA removed their assignment Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: On Hold
Development

No branches or pull requests

1 participant