Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot needs updating to be deployed #205

Open
nzakas opened this issue Mar 28, 2024 · 2 comments · Fixed by #208
Open

Bot needs updating to be deployed #205

nzakas opened this issue Mar 28, 2024 · 2 comments · Fixed by #208
Assignees
@aladdin-add
Labels
accepted bug build

Comments

@nzakas
Copy link
Member

nzakas commented Mar 28, 2024

The last deploy failed, apparently because we're still using Node.js 16.

I tried manually updating everything to use Node.js 20, but that causes all kinds of errors in the CI tests.

As best I can tell, we need to:

  1. Ensure we're using Node.js 20 or higher throughout the CI and server
  2. Upgrade any dependencies that don't work in Node.js 20+
  3. Ensure CI testing works properly
@eslintbot eslintbot added this to Triage Mar 28, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 28, 2024
@aladdin-add
Copy link
Member

I can take it. 😄

@aladdin-add aladdin-add self-assigned this Mar 29, 2024
@aladdin-add aladdin-add moved this from Needs Triage to Ready to Implement in Triage Mar 29, 2024
@nzakas nzakas mentioned this issue Mar 29, 2024
Merged
@aladdin-add aladdin-add mentioned this issue Apr 2, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Ready to Implement to Complete in Triage May 11, 2024
aladdin-add added a commit that referenced this issue May 17, 2024
@aladdin-add
fix: revert node v20 & upgrade deps
063937c 
it reverts the following commits:
* 76601d6
* 9c480a2
* 4a5cccd

it reopen the issue: #205

fixes #212
@aladdin-add aladdin-add mentioned this issue May 17, 2024
Merged
aladdin-add added a commit that referenced this issue May 17, 2024
@aladdin-add
fix: revert node v20 & upgrade deps
4b444f8 
it reverts the following commits:
* 76601d6
* 9c480a2
* 4a5cccd

it reopens the issue: #205

fixes #212
@aladdin-add aladdin-add reopened this May 21, 2024
@github-project-automation github-project-automation bot moved this from Complete to Evaluating in Triage May 21, 2024
@nzakas
Copy link
Member Author

nzakas commented Jan 7, 2025

I'm looking into this as the bot is breaking again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aladdin-add aladdin-add

Labels
accepted bug build
Projects
Triage
Status: Evaluating
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: upgrade node v20 & upgrade deps eslint/eslint-github-bot
2 participants
@nzakas @aladdin-add