Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Upstream Wi-Fi registers. #277

Closed
Frostie314159 opened this issue Sep 1, 2024 · 3 comments · Fixed by #284
Closed

[RFC] Upstream Wi-Fi registers. #277

Frostie314159 opened this issue Sep 1, 2024 · 3 comments · Fixed by #284
Labels
registers Something is wrong with one or more registers RFC Request for comment

Comments

@Frostie314159
Copy link
Contributor

Hi, I'm currently in the process of implementing a Wi-Fi stack for the ESP32 in pure rust and I have to use raw pointer to access the registers, we found while reversing.
I wanted to ask if we could upstream our patches for the SVD, to access them through esp-hal, or should maintain them out of tree.

@MabezDev
Copy link
Member

MabezDev commented Sep 2, 2024

It should be fine to upstream your findings to the PACs, we're unlikely to use them in esp-wifi (unless you figured it all out :D) but I see no harm in them being there, provided they are of decent quality.

@Frostie314159
Copy link
Contributor Author

Yeah, they're probably not of much use for esp-wifi. The thing is, that most of these names are educated guesses at best, since they have like two references and some random value is written to them. Some are more obvious, like 0x3ff73090, which is referenced in hal_mac_rx_get_last_dscr. I'd suggest putting them behind a feature flag.

@MabezDev MabezDev transferred this issue from esp-rs/esp-hal Sep 4, 2024
@Frostie314159
Copy link
Contributor Author

@MabezDev I made a small tech demo over at: https://github.com/esp32-open-mac/esp32-wifi-hal-rs we can send, receive and change the channel. TX and RX is completely async, and we only need the blobs for RF init and some minor initialization.

@jessebraham jessebraham added the registers Something is wrong with one or more registers label Sep 9, 2024
@jessebraham jessebraham added the RFC Request for comment label Oct 25, 2024
@jessebraham jessebraham linked a pull request Oct 25, 2024 that will close this issue
13 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
registers Something is wrong with one or more registers RFC Request for comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants