-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The esp32-arduino core should bundle pyserial, so esptool works #9689
Comments
That needs major changes. You can't install just py serial. You need a Pyenv for Arduino to have all rights to install and don't disturb the system installed python. So a check for pyenv is needed and when not there it needs to be installed. To do so python for all systems needs to be provided. |
(I assume you mean venv, not pyenv?) You don't actually need a venv to add a bundled module, you can just edit For making portable self contained Python based executables (that bundle Python itself and any needed modules), I hear good things about PyOxidizer; I don't know if it would be compatible with pyserial. |
Been there. Believe me only way that will work is to have a extra venv when requirements needs to be installed. Every other try will not work on a platform. Arduino esp8266 is doing that and Platformio (for every framework) too. |
Just seems like there should be some better way. We do bundle a full Python installation for Windows? |
What's wrong to provide a small python package. It is around 7MB. |
You mean the Python binary itself (along with whatever libraries are needed)? Sounds good to me! |
Related area
platform support for esptool
Hardware specification
(relevant to all)
Is your feature request related to a problem?
If pyserial is not installed on the base system, esptool can't run, and because of espressif/esptool#981 you just get a stack trace and "No module named 'serial'" which isn't the most helpful, particularly for people using the Arduino IDE not conversant with Python.
This also makes the install-on-Linux instructions a lot more complicated than they have to be. Should just be a matter of adding the board manager URL.
Describe the solution you'd like
Somehow, when installing the arduino-esp32 platform, pyserial should get installed alongside other things.
Describe alternatives you've considered
No response
Additional context
No response
I have checked existing list of Feature requests and the Contribution Guide
The text was updated successfully, but these errors were encountered: