Questions about get_shuffling()

[paulhauner]

beacon_chain/beacon_chain/state/state_transition.py

Lines 59 to 62 in 8192419

	if validator_count < rand_max:
	replacement_pos = (m % remaining) + i
	o[i], o[replacement_pos] = o[replacement_pos], o[i]
	i += 1

I'm going through the get_shuffling() function and I don't quite understand the logic here regarding rand_max. As I understand it, the program says presently that if validator_count > (max_validators / 2) then we should not shuffle and go into an infinite loop.

I assume the infinite loop thing is an extra indentation where there shouldn't be on line 62. However, I don't understand the "don't shuffle if validator_count < rand_max logic" (this condition is true whenever validator_count <= (max_validators / 2)).

Thanks! 🙂

[paulhauner]

FYI I have a get_shuffling() implementation here which expresses how I understand it should work.

[djrtwo]

Closed in favor of #18

[djrtwo]

Whoops, wrong closure

[paulhauner]

Closed in favor of #57