From ce61a90cb3ff98cf9c9a774c30082624859923d4 Mon Sep 17 00:00:00 2001 From: lorenzourb Date: Sun, 17 Dec 2023 10:25:12 +0100 Subject: [PATCH 1/2] forcing oneOf breaks the schema validation due to dups --- src/schemas/filter.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/schemas/filter.yaml b/src/schemas/filter.yaml index 2d4542046..99cbf19d5 100644 --- a/src/schemas/filter.yaml +++ b/src/schemas/filter.yaml @@ -1,6 +1,6 @@ FilterResults: title: Filter results - oneOf: + anyOf: - title: new block hashes type: array items: From 14592cfc6defa5aeff7f2c1d426a7241c02d1ed6 Mon Sep 17 00:00:00 2001 From: lorenzourb Date: Wed, 20 Dec 2023 14:30:58 +0100 Subject: [PATCH 2/2] code review agreed changes --- src/schemas/filter.yaml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/schemas/filter.yaml b/src/schemas/filter.yaml index 99cbf19d5..a2ed1432e 100644 --- a/src/schemas/filter.yaml +++ b/src/schemas/filter.yaml @@ -1,11 +1,7 @@ FilterResults: title: Filter results - anyOf: - - title: new block hashes - type: array - items: - $ref: '#/components/schemas/hash32' - - title: new transaction hashes + oneOf: + - title: new block or transaction hashes type: array items: $ref: '#/components/schemas/hash32'