Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7685 tests due to execution-apis#622 #1077

Open
marioevz opened this issue Jan 14, 2025 · 0 comments
Open

Update EIP-7685 tests due to execution-apis#622 #1077

marioevz opened this issue Jan 14, 2025 · 0 comments

Comments

@marioevz
Copy link
Member

Tests need update to return an Engine API error in some of the invalid_requests_block_combinations tests for EIP-7685 due to ethereum/execution-apis#622:

  • no_requests_invalid_hash_calculation_method*
  • incorrect_order_*
  • duplicate_*_request
  • extra_empty_request
  • extra_invalid_type_request

single_*_missing_type_byte and single_*_empty_requests_list might produce the error but could be that depending on the contents of the request, it could not return it, so it might be worth to rework the test to make the invalidity more deterministic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant