Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong output of denormalized numbers #176

Closed
klux21 opened this issue Feb 24, 2024 · 4 comments
Closed

Wrong output of denormalized numbers #176

klux21 opened this issue Feb 24, 2024 · 4 comments

Comments

@klux21
Copy link

klux21 commented Feb 24, 2024

Just because I did spot that: vsprintf_(ps, "%+#27.6e", (double) 1.59456123e-317);
Should generate " +1.594561e-317" instead of " +0.000000e-309" .

Just a hint for solving that: While the mantissa is below 1 it needs to be multiplied by 10 until it's above 1 and the exponents needs to be decreased that often.

@eyalroz
Copy link
Owner

eyalroz commented Feb 26, 2024

The library does not currently handle denormals properly, see #72. Unfortunately I am somewhat indisposed to work on this at the moment, especially with the war and everything; but I would be more than happy to review a PR improving their handling.

@klux21
Copy link
Author

klux21 commented Feb 26, 2024

Right because of the wars I did change the license of my little projects now to one that prohibits any usage in weapons now. I wish you to get well over that war!

@eyalroz
Copy link
Owner

eyalroz commented Feb 26, 2024

@klux21 : I feel like Israeli society has gradually devolved into some combination of ISIS meets Nazi Germany. I literally have to try to argue with people about why Gazans are human beings like us who deserve to live and not be killed.

Anyway - do you agree that this is a duplicate of #72?

@klux21
Copy link
Author

klux21 commented Feb 27, 2024

You are right - it seems to be a duplicate. I didn't spot the other bug.

War propaganda is always the same and most of the people usually are believing that. It will even gets worse the longer the war lasts.

@eyalroz eyalroz closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants