-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse mesh url from url-param search query to load https://f3d.app/web?mesh={mesh_url} #1595
Comments
This would be a nice improvement indeed!
Doing it with a hash seems better in this case actually. If there was anything to do server side we'd need to pass the parameters in the Basically, after the page is loaded and the viewer is set up, the script would look after the
I believe @Meakk recently improved the build/packaging of the wasm version so he may be able to get you started. You may even be able to get away with editing |
This code is only used to recommend the correct download on the Website, it's unrelated to F3D web.
Sounds like a good idea. You have to download the file to a I don't know the implementation details (maybe this page could help?), it's more about web development knowledge than F3D codebase knowledge at this point (and nobody is a web developer in regular contributors as far as I know) If you want to give it a try, you can build and test F3D WASM very easily by following the guide (Linux, Docker and npm required) |
Thanks both for the helpers. I just implemented the suggested changes that I think should allow parsing of a Here are the suggested changes Should I make a PR to include them? Thanks! |
Yes please :) |
For those stumbling here, implementation is done and PR awaiting merge here! #1596 |
PR just got merged and is live, thanks to everyone for the feedback!
|
Hey @jo-chemla , We have been discussing on discord possible improvements, but it looks like you did not finish onboarding there so I cant add you to that discussion, do you wanna try communicate there ? |
Hi @mwestphal, I'll try to have a look but I avoid my discord which is pretty overloaded. If you want to summarize the discussion in this thread for possible improvements, please don't hesitate! Just accepted your request though! |
Definitely, discord is not great for feature discussion. |
Created a new thread to track these improvements |
Is your feature request related to a problem? Please describe.
Long-time f3d user, however I just discovered the https://f3d.app/web WASM build which does look great so thanks a lot! It would be great if one could pass to the viewer a url-param which indicates a mesh file to load.
Describe the solution you'd like
f3d could parse mesh url given search query like the following: https://f3d.app/web?mesh={mesh_url}
Regarding at how the webassembly/app.html loads supported meshes on file select, it seem that this could be hacked to initially load a model if the urlparam search query is detected.
Some
os
urlparams seem to be parsed here, but only to know which os to look for the wasm build.Describe alternatives you've considered
3dviewer.net does it this way - although a weird hash # replaces the question-mark in the search-query: https://3dviewer.net/#model=${mesh_url}.
Additional context
This would make it easier to inspect mesh files lying accessible on the web via a server endpoint using f3d. My interest is integrating f3d within STAC-browser (Spartio-Temporal Asset Catalogs) which is made to explore and standardize geospatial assets, among which meshes are an important part - see PR here for context
Contribution
Would love to contribute, although I don't know mulch about the f3d codebase. Would need some pointers, the implementation probably has to happen in the app.html file, but building/bundling the wasm seem hard once implementation is finished.
The text was updated successfully, but these errors were encountered: