Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take advantage of libf3d C++17 API #1624

Closed
mwestphal opened this issue Sep 15, 2024 · 1 comment
Closed

Take advantage of libf3d C++17 API #1624

mwestphal opened this issue Sep 15, 2024 · 1 comment
Assignees
@mwestphal
Labels
source:libf3d type:enhancement New feature or request
Milestone
3.0.0

Comments

@mwestphal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
libf3d recently switched to C++17 in order to support optional options.
However more API could be improved thanks to C++17 feature.

std::filesystem comes to mind

Describe the solution you'd like
Needs investigation
@mwestphal mwestphal added type:enhancement New feature or request source:libf3d labels Sep 15, 2024
@mwestphal mwestphal added this to F3D Sep 15, 2024
@mwestphal mwestphal moved this to Investigate in F3D Sep 15, 2024
@mwestphal mwestphal mentioned this issue Sep 15, 2024
Merged
@mwestphal mwestphal added this to the 3.0.0 milestone Dec 19, 2024
@mwestphal mwestphal self-assigned this Dec 21, 2024
@mwestphal mwestphal mentioned this issue Dec 23, 2024
Merged
mwestphal added a commit that referenced this issue Dec 26, 2024
@mwestphal
libf3d: Improve API for [[nodiscard]] and missing this* return (#1830)
fda96ea 
 - Adding [[nodiscard]] on all method where it makes sense
 - Updating test to use std::ignore when needed
 - Return this* whenever is was missing
 - Part of #1624
@mwestphal mwestphal mentioned this issue Dec 26, 2024
Merged
@mwestphal
Copy link
Contributor Author

mwestphal commented Jan 3, 2025 •
edited
Loading

Done :

@github-project-automation github-project-automation bot moved this from Investigate to Done in F3D Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwestphal mwestphal

Labels
source:libf3d type:enhancement New feature or request
Projects
F3D
Status: Done
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@mwestphal