Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --format=pigz & --format=pxz multi-threaded support #1592

Closed
centminmod opened this issue Apr 18, 2019 · 3 comments
Closed

add --format=pigz & --format=pxz multi-threaded support #1592

centminmod opened this issue Apr 18, 2019 · 3 comments

Comments

@centminmod
Copy link

I just finished some zstd 1.4.0 benchmarks including testing --format=gzip and --format=xz options and they seem to be single threaded. Would love to see zstd support multithreaded gzip via pigz and multithreaded xz via pxz as well for --format=pigz & --format=pxz :)

@terrelln
Copy link
Contributor

I didn't look that closely, but it looks like those tools don't provide libraries, only command line tools.

Zstd uses the zlib and lzma libraries to provide support for --format=gzip and --format=xz. We'd have to shell out to the the respective CLIs to support pigz and pxz. I'd rather not do that.

If there widely used library for parallel xz or parallel zlib, I'd be happy to accept a PR that adds support.

@centminmod
Copy link
Author

centminmod commented Apr 19, 2019

cheers @terrelln wouldn't I don't know inner workings of pigz or pxz or if there are such libraries or not.

I believe pigz issue was posted at madler/pigz#50

@Cyan4973
Copy link
Contributor

Closing. Such a feature would require advanced dependencies, that we prefer not to depend upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants