Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: support Cargo.toml workspace at / #51

Open
rbtcollins opened this issue Jan 7, 2025 · 1 comment · May be fixed by #54
Open

enh: support Cargo.toml workspace at / #51

rbtcollins opened this issue Jan 7, 2025 · 1 comment · May be fixed by #54

Comments

@rbtcollins
Copy link

rbtcollins commented Jan 7, 2025 •
edited
Loading

We like our developers to be able to use Cargo directly in parallel with the monorepo build system (because rust-analyzer works better that way still), and so we have /Cargo.toml as a workspace with all our packages and all the third-party crates referenced there.

But I would like to output the buckified BUCK file to third-party/rust/crates/BUCK

Any objections to such a feature?
@cormacrelf
Copy link
Contributor

We have been using a step that copies the [workspace.dependencies] section of the workspace Cargo.toml to a third party dir, adding a dummy [package] and renaming [workspace.dependencies] to [dependencies]. And copying Cargo.lock there. Altogether this simulates having a single cargo package with a bunch of normal dependencies, and we use include_top_level = true with that.

So yeah, that's not ideal, it'd be nice to have this feature.

@cormacrelf cormacrelf linked a pull request Jan 10, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workspace cargo toml support cormacrelf/reindeer
2 participants
@cormacrelf @rbtcollins