-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing / coordinate issues for diplomatic transcripts #13
Comments
The main remaining issue is an inclusion problem that can be observed by replacing I've no idea where this scaling comes from and how to avoid it. It even appears in debug2.html, which is very simplistic, so its probably somewhere in the CSS? |
When using SlimerJS instead of PhantomJS, the horizontal offsets are even in the generated PDF – cf., e.g., the interpunction at the end of lines in lower parts of 2 H p. 109 |
This is the same bug as (or rather underlying cause of) faustedition/faust-web#22. I prefer the discussion in this project (faust-gen) as it is the appropriate place, but that other issue contains valuable information, too. |
As an experiment, I've modified the CSS in order to use the browser's default fonts (CSS font family names |
It might be a workaround to try to prepare a browser profile that uses Ubuntu / Gentium / Ubuntu Mono as default fonts for sans-serif / serif / monospace … |
Possible workaround for #13, but attn! installs our fonts to the user's profile! (or at least tries to …)
It seems as if underlinings are expanded as a result of the longer boxes: |
In c27fc3d and b861c52, I included Web Font Loader (https://github.com/typekit/webfontloader). This is what is used by https://github.com/millermedeiros/requirejs-plugins which @thvitt mentioned. |
Build still delivers a different result than running the maven script by hand, this is all very strange |
Maybe headless chromium is worthwhile evaluating, e.g., remote controlled using selenium or chrome-remote-interface. PhantomJS is not developed any longer, and SlimerJS development seems to have stalled, as well. |
Here an example (2 III H.1 S.5, differences marked: |
This currently mirrors renderToPhantom but return a promise instead of calling PhantomJS's callback, making it usable from, e.g., puppeteer. Cf. #13
See also faustedition/faust-web#22
The pre-generation of the diplomatic transcript SVGs causes spacing / scaling issues for the typeset texts. Differences can be observed in the dev version using the bug and pdf buttons.
The text was updated successfully, but these errors were encountered: