Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FIP Editor Expectations #1097

Closed
momack2 opened this issue Jan 6, 2025 · 1 comment
Closed

Update FIP Editor Expectations #1097

momack2 opened this issue Jan 6, 2025 · 1 comment
Assignees
@luckyparadise

Comments

@momack2
Copy link
Contributor

momack2 commented Jan 6, 2025

update the FIP editor expectation to document that for PRs that change the protocol design/spec or considerations, FIP editors should make sure there exists at least two appropriate technical reviews & approvals before considering the PR is ready to merge
@luckyparadise
Copy link
Collaborator

@momack2 this is contained in the Fip Editor Handbook which I have just pushed as a PR here. Please check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luckyparadise luckyparadise

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@momack2 @luckyparadise