Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inline bracket notation to protect all functions from minification #28

Open
sergiopantoja opened this issue Nov 26, 2013 · 0 comments

Comments

@sergiopantoja
Copy link
Contributor

Since we eventually want to concatenate, minify, and compress our Javascript files, we have to make sure that our application is "minification-safe" (which means that it will still work properly if we minify the code). I'm sure there are many functions that need to be fixed for this. It's basically changing this:

angular.module('foo').controller('FooCtrl', function($scope, $foo, $bar) {
    // ...
});

To this:

angular.module('foo').controller('FooCtrl', ['$scope', '$foo', '$bar', function($scope, $foo, $bar) {
    // ...
}]);

More info:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant